Skip to content

feat: Enable Reader to be more pass-through to guess mimetype - #299

Merged
tmathern merged 13 commits into
mainfrom
mathern/guess-reader-type
Jul 27, 2026
Merged

feat: Enable Reader to be more pass-through to guess mimetype#299
tmathern merged 13 commits into
mainfrom
mathern/guess-reader-type

Conversation

@tmathern

@tmathern tmathern commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request

  • Allow Reader to pass through an empty mimetype string to the native library, so the native lib attempts to guess the type of file.
  • Still request the mimetype/format on Builder when signing.

Stream-only overloads for Reader will be in #301.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@tmathern tmathern self-assigned this Jul 22, 2026
@tmathern
tmathern marked this pull request as ready for review July 24, 2026 14:33
@tmathern
tmathern requested review from ale-adobe and ok-nick July 24, 2026 16:33
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py
@tmathern
tmathern requested review from gpeacock and ok-nick July 27, 2026 16:31
Comment thread src/c2pa/c2pa.py
Comment thread src/c2pa/c2pa.py

@gpeacock gpeacock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this captures the same thing that the sdk does, or if it should.

Comment thread src/c2pa/c2pa.py Outdated
Comment thread src/c2pa/c2pa.py
Comment thread tests/test_unit_tests.py
@tmathern
tmathern merged commit 28eef14 into main Jul 27, 2026
27 checks passed
@tmathern
tmathern deleted the mathern/guess-reader-type branch July 27, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants